Fix more check/mypy --next errors #5450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabacon
requested review from
wcourtney,
a team,
vtomole,
cduck and
verult
as code owners
viathor
approved these changes
Jun 6, 2022
| @@ -314,7 +314,8 @@ def measure_state_vector( | |||
| out.shape = initial_shape | |||
| out /= np.sqrt(probs[result]) | |||
|
|
|||
| return measurement_bits, out | |||
| # We mutate and return out, so mypy cannot identify that the out cannot be None. | |||
There was a problem hiding this comment.
Would it be able to do so if we added assert out is not None either right here or on line 307 above?
As a matter of principle, I think we should prefer code over comments whenever possible in order to help python/mypy/etc help us :-)
There was a problem hiding this comment.
Oh much better thanks!
| @@ -314,7 +314,8 @@ def measure_state_vector( | |||
| out.shape = initial_shape | |||
| out /= np.sqrt(probs[result]) | |||
|
|
|||
| return measurement_bits, out | |||
| # We mutate and return out, so mypy cannot identify that the out cannot be None. | |||
There was a problem hiding this comment.
Incidentally, I think the type annotation on out should be Optional[np.ndarray]. Might as well fix it while you're in the neighborhood.
dabacon
added
the
automerge
|
Automerge cancelled: A status check is failing. |
CirqBot
removed
the
automerge
viathor
reviewed
Jun 6, 2022
dabacon
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.