pr_monitor: post empty string as commit message if PR body is empty #5458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabacon
approved these changes
Jun 6, 2022
dev_tools/pr_monitor.py
Outdated
| @@ -772,7 +772,7 @@ def attempt_squash_merge(pr: PullRequestDetails) -> Union[bool, CannotAutomergeE | |||
| ) | |||
| data = { | |||
| 'commit_title': f'{pr.title} (#{pr.pull_id})', | |||
| 'commit_message': pr.body, | |||
| 'commit_message': pr.body if pr.body is not None else '', | |||
There was a problem hiding this comment.
think this can be pr.body or ''
verult
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…uantumlib#5458) Fixes quantumlib#4412 Verified in my personal fork via curling the API directly. @MichaelBroughton cc @dabacon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4412
Verified in my personal fork via curling the API directly.
@MichaelBroughton
cc @dabacon