Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazily load scipy.linalg #5461

Merged
merged 2 commits into from
Jun 7, 2022
Merged

Lazily load scipy.linalg #5461

merged 2 commits into from
Jun 7, 2022

Conversation

dabacon
Copy link
Collaborator

@dabacon dabacon commented Jun 6, 2022

Keep import down by not importing scipy.

@dabacon dabacon requested review from a team, vtomole and cduck as code owners June 6, 2022 23:23
@dabacon dabacon requested a review from mpharrigan June 6, 2022 23:23
@CirqBot CirqBot added the Size: XS <10 lines changed label Jun 6, 2022
MichaelBroughton
MichaelBroughton approved these changes Jun 7, 2022
View reviewed changes
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelBroughton MichaelBroughton self-assigned this Jun 7, 2022
@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 7, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 7, 2022
@CirqBot CirqBot merged commit 280502f into quantumlib:master Jun 7, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jun 7, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@dabacon @rht
Lazily load scipy.linalg (quantumlib#5461)
7d732e3 
Keep import down by not importing scipy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelBroughton MichaelBroughton MichaelBroughton approved these changes

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@mpharrigan mpharrigan Awaiting requested review from mpharrigan mpharrigan was automatically assigned from quantumlib/cirq-maintainers

Assignees

@MichaelBroughton MichaelBroughton

Labels
Size: XS <10 lines changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dabacon @MichaelBroughton @CirqBot