Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary state copy #5469

Merged
merged 2 commits into from
Jun 8, 2022
Merged

Remove unnecessary state copy #5469

merged 2 commits into from
Jun 8, 2022

Conversation

daxfohl
Copy link
Contributor

@daxfohl daxfohl commented Jun 8, 2022

Removes the copy when simulating params. #3494 (comment) for discussion. @95-martin-orion

@daxfohl daxfohl requested review from a team, vtomole and cduck as code owners June 8, 2022 01:29
@CirqBot CirqBot added the size: S 10< lines changed <50 label Jun 8, 2022
@daxfohl daxfohl mentioned this pull request Jun 8, 2022
Closed
95-martin-orion
95-martin-orion approved these changes Jun 8, 2022
View reviewed changes
Copy link
Collaborator

@95-martin-orion 95-martin-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One less copy can make the difference between fitting in RAM or not for large circuits - thanks for catching this!

@95-martin-orion 95-martin-orion added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 8, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 8, 2022
@CirqBot CirqBot merged commit cf12920 into quantumlib:master Jun 8, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jun 8, 2022
@daxfohl daxfohl deleted the fix-copy branch June 8, 2022 23:20
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@daxfohl @rht
Remove unnecessary state copy (quantumlib#5469)
4a16417 
Removes the copy when simulating params. quantumlib#3494 (comment) for discussion. @95-martin-orion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@95-martin-orion 95-martin-orion 95-martin-orion approved these changes

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@MichaelBroughton MichaelBroughton Awaiting requested review from MichaelBroughton MichaelBroughton was automatically assigned from quantumlib/cirq-maintainers

Assignees
No one assigned
Labels
size: S 10< lines changed <50
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@daxfohl @95-martin-orion @CirqBot