Make moment str/text diagrams stable (independent of insertion order) #5474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Amazed that this does not break any tests!!!! |
|
@dabacon The PR is ready for a re-review. PTAL! |
dabacon
requested changes
Jun 14, 2022
cirq-core/cirq/circuits/moment.py
Outdated
| @@ -91,6 +91,7 @@ def __init__(self, *contents: 'cirq.OP_TREE') -> None: | |||
| ValueError: A qubit appears more than once. | |||
| """ | |||
| self._operations = tuple(op_tree.flatten_to_ops(contents)) | |||
| self._sorted_operations = tuple(sorted(self._operations, key=lambda op: op.qubits)) | |||
There was a problem hiding this comment.
I'm a bit worried about hit we take here for time and memory. Already our circuit code isn't particularly fast and this doubles the memory and time for constructing moments.
Does it make sense to maybe have this be a cached value (like measurement key obs and control keys) that is only populated when used?
There was a problem hiding this comment.
done, although I think it would have little value since sorted operations is used in common functions like to_text_diagram and _eq_.
…nto origin/fix_moment_str
tanujkhattar
requested review from
mrwojtek,
ColemanCollins,
nakardo,
gmauricio,
wcourtney and
verult
as code owners
|
@dabacon This is ready for another review. PTAL. |
tanujkhattar
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5404