Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document noise representations #5495

Merged
merged 12 commits into from
Jun 23, 2022

Conversation

95-martin-orion
Copy link
Collaborator

Doc for capturing different representations of noise in Cirq.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CirqBot CirqBot added the size: L 250< lines changed <1000 label Jun 13, 2022
@95-martin-orion
Copy link
Collaborator Author

CC @augustehirth

This is my initial pass at the doc we discussed - how close is it to what you had in mind? Are there any topics missing? Should we include code examples?

@95-martin-orion
Copy link
Collaborator Author

Tests are blocked on #5480.

@95-martin-orion 95-martin-orion marked this pull request as ready for review June 15, 2022 16:31
@95-martin-orion 95-martin-orion requested review from a team, vtomole and cduck as code owners June 15, 2022 16:31
@95-martin-orion
Copy link
Collaborator Author

Quantum walks doc got caught by the auto-formatter, it can be ignored.

Copy link
Collaborator

@augustehirth augustehirth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@95-martin-orion 95-martin-orion added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 23, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 23, 2022
@CirqBot CirqBot merged commit e99d9ca into quantumlib:master Jun 23, 2022
@CirqBot CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 23, 2022
@CirqBot CirqBot removed the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 23, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Doc for capturing different representations of noise in Cirq.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: L 250< lines changed <1000
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants