Dont include global phase gate in decomposition of parameterized CCZPow gate when global_shift is 0 #5504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow gate when global_shift is 0
MichaelBroughton
approved these changes
Jun 13, 2022
MichaelBroughton
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…ow gate when global_shift is 0 (quantumlib#5504) This helps ensure that, whenever global_shift is 0, parameterized three qubit gates can decompose into 2q gates accepted by common gatestets like IonQTargetGateset, which don't accept global phase gate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps ensure that, whenever global_shift is 0, parameterized three qubit gates can decompose into 2q gates accepted by common gatestets like IonQTargetGateset, which don't accept global phase gate.