Deprecate cirq.neutral_atoms module #5519
Conversation
tanujkhattar
requested review from
HGSilveri,
a team,
vtomole and
cduck
as code owners
| @@ -31,6 +30,23 @@ def _subgate_if_parallel_gate(gate: 'cirq.Gate') -> 'cirq.Gate': | |||
| return gate.sub_gate if isinstance(gate, ops.ParallelGate) else gate | |||
|
|
|||
|
|
|||
| def neutral_atom_gateset(max_parallel_z=None, max_parallel_xy=None): | |||
There was a problem hiding this comment.
What's the point of keeping this? Should we fold this into cirq-pasqal as well?
There was a problem hiding this comment.
This method exists because both the deprecated classes (NeutralAtomDevice and ConvertToNeutralAtomGates) instantiate a gateset using this method. Once the deprecated classes are removed after deprecation, this method would also be removed.
Since this method is not exported to the top level cirq modules, I don't think we need to go through a deprecation cycle for this method.
tanujkhattar
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
|
Automerge cancelled: A status check is failing. |
CirqBot
removed
automerge
tanujkhattar
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
|
Automerge cancelled: A required status check is not present. Missing statuses: ['Misc check', 'Notebook formatting', 'Pytest MacOS (3.9)', 'Pytest Ubuntu (3.7)', 'Pytest Ubuntu (3.8)', 'Pytest Ubuntu (3.9)', 'Pytest Windows (3.7)', 'Pytest Windows (3.8)', 'Pytest Windows (3.9)', 'Type check', 'Typescript lint check', 'Typescript tests', 'Typescript tests coverage'] |
CirqBot
removed
automerge
Co-authored-by: Cirq Bot <craiggidney+github+cirqbot@google.com>
Part of #2793