Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace shell_tools.run_cmd --> shell_tools.run #5550

Merged
merged 4 commits into from
Jun 20, 2022
Merged

Replace shell_tools.run_cmd --> shell_tools.run #5550

merged 4 commits into from
Jun 20, 2022

Conversation

pavoljuhas
Copy link
Collaborator

Stop using shell_tools.run_cmd which is slated for removal.

Partially implements #4394

@pavoljuhas
Replace shell_tools.run_cmd --> shell_tools.run
f6d6f1a
@pavoljuhas
test_isolated_env_cloning - pass error output from the pip job
2d6e672 
Do not capture stderr from the pip process.
Leave it in the default error stream in case it is needed for diagnostics.
@pavoljuhas pavoljuhas requested review from a team, vtomole and cduck as code owners June 17, 2022 21:08
@pavoljuhas pavoljuhas requested a review from verult June 17, 2022 21:08
@CirqBot CirqBot added the size: M 50< lines changed <250 label Jun 17, 2022
@pavoljuhas
Fix mypy issues in git_env_tools
2622046 
Use PreparedEnv.actual_commit_id as a run argument only when set.
MichaelBroughton
MichaelBroughton approved these changes Jun 20, 2022
View reviewed changes
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great looking code! LGTM

@MichaelBroughton MichaelBroughton self-assigned this Jun 20, 2022
@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 20, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 20, 2022
@CirqBot CirqBot merged commit b1f8a5e into quantumlib:master Jun 20, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jun 20, 2022
@pavoljuhas pavoljuhas deleted the replace-shell_tools.run_cmd branch June 21, 2022 16:56
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@pavoljuhas @rht
Replace shell_tools.run_cmd --> shell_tools.run (quantumlib#5550)
3fda88a 
Stop using shell_tools.run_cmd which is slated for removal.

Partially implements quantumlib#4394
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelBroughton MichaelBroughton MichaelBroughton approved these changes

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@verult verult Awaiting requested review from verult verult was automatically assigned from quantumlib/cirq-maintainers

Assignees

@MichaelBroughton MichaelBroughton

Labels
size: M 50< lines changed <250
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pavoljuhas @MichaelBroughton @CirqBot