Add async methods to AbstractEngine and AbstractJob #5555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maffoo
force-pushed
the
u/maffoo/abstract-engine-async
branch
2 times, most recently
from
8d70ffc
to
2a36c26
Compare
maffoo
force-pushed
the
u/maffoo/abstract-engine-async
branch
from
2a36c26
to
d12b0ca
Compare
maffoo
requested review from
wcourtney,
a team,
vtomole,
cduck and
verult
as code owners
95-martin-orion
requested changes
Jul 11, 2022
cirq-core/cirq/work/sampler.py
Outdated
| ) -> Sequence[Sequence['cirq.Result']]: | ||
| """Runs the supplied circuits. | ||
|
|
||
| This is an asynchronous version of `run_batch`. |
There was a problem hiding this comment.
Document args / return value.
There was a problem hiding this comment.
My idea here was just to refer to run_batch rather than repeat the same docs here. I've added a note to make this more explicit.
There was a problem hiding this comment.
Seems OK since these are on the same page in the docs site. Would be nice if we could link, but I'm not 100% certain whether cirq.Sampler.run_batch would auto-link properly with the tfdocs tools.
95-martin-orion
approved these changes
Jul 12, 2022
|
Gonna go ahead and merge. I'll follow up with doc fixes if I can figure out how to get code references to render as links. |
CirqBot
pushed a commit
that referenced
this pull request
Jul 12, 2022
Follow-up to #5555 to fix docs.
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Follow-up to quantumlib#5555 to fix docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds abstract async
run_*methods toAbstractEngine,AbstractProcessor, andAbstractJob, withduet.syncwrappers to preserve the current sync API. This requires a new version of duet to supportduet.syncon abstract methods.Also modified the underlying
cirq.Samplerbase class to support either implementingrun_sweepin terms ofrun_sweep_asyncor the other way around, depending on whether the underlying sampler supports asynchrony with futures, e.g. if it makes calls to a remote service.