Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate cirq.ion module #5563

Merged
merged 4 commits into from
Jun 21, 2022
Merged

Conversation

tanujkhattar
Copy link
Collaborator

Fixes #2793
Fixes #5128

@CirqBot CirqBot added the size: M 50< lines changed <250 label Jun 21, 2022
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do we want to deprecate cirq.ion like we did with cirq.google or does getting all the major things inside of it seem like enough ?

cirq-core/cirq/ion/ion_device_test.py Show resolved Hide resolved
@tanujkhattar
Copy link
Collaborator Author

do we want to deprecate cirq.ion like we did with cirq.google or does getting all the major things inside of it seem like enough

Since we have deprecated everything inside the module, we don't need to deprecate the cirq.ion submodule itself. The latter is needed when we are moving utilities but want the users to update the path (for example, use cirq_google.Sycamore instead of cirq.google.Syamore). In this case, no object inside the cirq.ion is preserved -- everything is replaced by newer alternatives and therefore just deprecating all the objects is enough.

@tanujkhattar tanujkhattar added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 21, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 21, 2022
@CirqBot CirqBot merged commit 3534a9b into quantumlib:master Jun 21, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jun 21, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AQT] Vendor Transformer adoption Proposal: move ion and neutral into devices
3 participants