Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Rigetti from local checks #5632

Merged
merged 2 commits into from
Jun 27, 2022
Merged

Remove Rigetti from local checks #5632

merged 2 commits into from
Jun 27, 2022

Conversation

dabacon
Copy link
Collaborator

@dabacon dabacon commented Jun 27, 2022

This remove the rigetti integration tests from the default of pytest-and-incremental-coverage and hence of all. It keeps these tests in the CI workflow.

The alternative to this would be to add the docker up and down to these scripts, but I'm hesitant to do this as these download external docker images.

Fixes #4660

@dabacon dabacon requested review from a team, vtomole and cduck as code owners June 27, 2022 22:15
@CirqBot CirqBot added the size: S 10< lines changed <50 label Jun 27, 2022
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dabacon dabacon added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 27, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 27, 2022
@CirqBot CirqBot merged commit abdb5b6 into quantumlib:master Jun 27, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jun 27, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
This remove the rigetti integration tests from the default of `pytest-and-incremental-coverage` and hence of `all`.  It keeps these tests in the CI workflow.  

The alternative to this would be to add the docker up and down to these scripts, but I'm hesitant to do this as these download external docker images.

Fixes quantumlib#4660
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

check/all fails because it runs rigetti tests
3 participants