Fix typing of the protocols.commutes() function #5651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Require the `default` argument of the `commutes()` function to be bool, None, or a local marker-type for raising TypeError. Use dedicated local marker-type _TRaiseTypeErrorIfNotProvided instead of np.array instance.
maffoo
reviewed
Jun 29, 2022
Return bool when the `default` argument is not specified. Otherwise allow return type to be the same as the `default` argument type.
pavoljuhas
changed the title
default argument in protocols.commutes
maffoo
approved these changes
Jun 30, 2022
pavoljuhas
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
|
Automerge cancelled: A status check is failing. |
CirqBot
removed
automerge
pavoljuhas
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Return bool when the `default` argument is not specified. Otherwise allow return type to be the same as the `default` argument type. Co-authored-by: Matthew Neeley <maffoo@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return bool when the
defaultargument is not specified.Otherwise allow return type to be the same as the
defaultargument type.Co-authored-by: Matthew Neeley maffoo@google.com