Remove CrossEntropyResult and CrossEntropyResultDict #5687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change Foxtail to Sycamore since Foxtail is deprecated. - Add some clarification that instructions are for linux.
- Also remove the whole cross_entropy_benchmarking.py since those were the last exposed objects from it. - Note that these were JSON serializable objects and the replacements are in reCirq. Thus, we just deserialize to a dictionary of values instead.
dstrain115
requested review from
mrwojtek,
a team,
vtomole and
cduck
as code owners
dabacon
reviewed
Jul 8, 2022
| purity_data = kwargs.get('purity_data', None) | ||
| if purity_data is not None: | ||
| purity_data = [(d, f) for d, f in purity_data] | ||
| return { |
There was a problem hiding this comment.
should this be a named tuple instead? that wa they actually mimic the way they are used for the previous data class? This is also works for the result dict.
There was a problem hiding this comment.
Ok, everything is deserialized into a NamedTuple now. What do you think?
dstrain115
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
|
Automerge cancelled: A required status check is not present. Missing statuses: ['Pytest MacOS (3.7)', 'Pytest MacOS (3.8)', 'Pytest MacOS (3.9)', 'Pytest Ubuntu (3.7)', 'Pytest Ubuntu (3.8)', 'Pytest Ubuntu (3.9)', 'Pytest Windows (3.7)', 'Pytest Windows (3.8)', 'Pytest Windows (3.9)', 'Typescript lint check', 'Typescript tests', 'Typescript tests coverage'] |
CirqBot
removed
automerge
dstrain115
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
- Also remove the whole cross_entropy_benchmarking.py
since those were the last exposed objects from it.
- Note that these were JSON serializable objects and the
replacements are in reCirq. Thus, we just deserialize to
a dictionary of values instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since those were the last exposed objects from it.
replacements are in reCirq. Thus, we just deserialize to
a dictionary of values instead.