Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused method SimulationState.with_qubits #5748

Merged

Conversation

pavoljuhas
Copy link
Collaborator

@pavoljuhas pavoljuhas commented Jul 13, 2022

Avoid contradictory use of the constructor state argument,
which is required for the SimulationState base class,
but unknown to its derived classes.

Closes #5721

Avoid constructor argument conundrum detailed in quantumlib#5721.

Closes quantumlib#5721
@pavoljuhas pavoljuhas requested review from a team, vtomole and cduck as code owners July 13, 2022 03:32
@pavoljuhas pavoljuhas requested a review from maffoo July 13, 2022 03:32
@CirqBot CirqBot added the size: S 10< lines changed <50 label Jul 13, 2022
@95-martin-orion 95-martin-orion added the BREAKING CHANGE For pull requests that are important to mention in release notes. label Jul 13, 2022
Copy link
Collaborator

@95-martin-orion 95-martin-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added BREAKING_CHANGE label for completeness. LGTM

@pavoljuhas pavoljuhas added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 13, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 13, 2022
@CirqBot CirqBot merged commit df782ff into quantumlib:master Jul 13, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 13, 2022
@pavoljuhas pavoljuhas deleted the remove-SimulationState.with_qubits branch July 13, 2022 16:35
@daxfohl daxfohl mentioned this pull request Mar 24, 2023
7 tasks
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Avoid contradictory use of the constructor `state` argument,
which is required for the SimulationState base class,
but unknown to its derived classes.

Closes quantumlib#5721
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE For pull requests that are important to mention in release notes. size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent use of state argument in SimulationState base and derived classes
3 participants