Increase timeout of a flaky speed test #5756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid flaky GitHub CI failures of Pytest MacOS (3.7).
viathor
approved these changes
Jul 13, 2022
| @@ -4652,11 +4652,16 @@ def test_create_speed(): | |||
| # Previously this took ~30s to run. Now it should take ~150ms. However the coverage test can | |||
| # run this slowly, so allowing 2 sec to account for things like that. Feel free to increase the | |||
| # buffer time or delete the test entirely if it ends up causing flakes. | |||
| # | |||
| # Updated in https://github.com/quantumlib/Cirq/pull/5756 | |||
There was a problem hiding this comment.
This looks like a performance regression. Could you file an issue and link to the issue instead of the PR? This way we're not going to loose track of the regression while avoiding the flaky failures for now.
There was a problem hiding this comment.
Ack - I have added a printout of the actual test durations locally on my linux box, which was
$ echo ' print("\\nDB: elapsed_time =", time.perf_counter() - t)' >> cirq-core/cirq/circuits/circuit_test.py
$ check/pytest -s -n 0 --cov --cov-config=dev_tools/conf/.coveragerc cirq-core/cirq/circuits/circuit_test.py -k test_create_speed | grep DB:
DB: elapsed_time = 0.4660000840012799- 0.48 s at ef40777 which introduced test_create_speed()
- 0.47 s at this PR
There is no significant change in test time - the failing CI is more likely due to fluctuating loads on the test machines.
pavoljuhas
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Increase timeout of `circuit_test.py::test_create_speed` from 2 to 4 seconds. Avoid flaky test failures of the GitHub CI Pytest MacOS (3.7).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase timeout of
circuit_test.py::test_create_speedfrom 2 to 4 seconds.Avoid flaky test failures of the GitHub CI Pytest MacOS (3.7).