Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add device specification to QVM #5771

Merged
merged 2 commits into from
Jul 15, 2022
Merged

Add device specification to QVM #5771

merged 2 commits into from
Jul 15, 2022

Conversation

dstrain115
Copy link
Collaborator

  • This implements the previously unimplemented
    get_device_specification in the SimulatedLocalProcessor
  • It adds an Optional constructor to populate the device_specification
  • Adds shims in virtual_engine_factory to populate this from the
    templates.

@dstrain115
Add device specification to QVM
bc02300 
- This implements the previously unimplemented
  `get_device_specification` in the SimulatedLocalProcessor
- It adds an Optional constructor to populate the device_specification
- Adds shims in virtual_engine_factory to populate this from the
  templates.
@CirqBot CirqBot added the size: M 50< lines changed <250 label Jul 15, 2022
@dstrain115 dstrain115 marked this pull request as ready for review July 15, 2022 02:57
@95-martin-orion 95-martin-orion added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 15, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 15, 2022
@CirqBot CirqBot merged commit a79896d into quantumlib:master Jul 15, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 15, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@dstrain115 @rht
Add device specification to QVM (quantumlib#5771)
8340afc 
- This implements the previously unimplemented
  `get_device_specification` in the SimulatedLocalProcessor
- It adds an Optional constructor to populate the device_specification
- Adds shims in virtual_engine_factory to populate this from the
  templates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@95-martin-orion 95-martin-orion 95-martin-orion approved these changes

@wcourtney wcourtney Awaiting requested review from wcourtney

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@verult verult Awaiting requested review from verult

Assignees
No one assigned
Labels
size: M 50< lines changed <250
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dstrain115 @95-martin-orion @CirqBot