Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix classically controlled op Moment diagram #5777

Merged
merged 5 commits into from
Jul 18, 2022

Conversation

daxfohl
Copy link
Contributor

@daxfohl daxfohl commented Jul 15, 2022

Fixes #5776 by accounting for the fact that args.label_map is null when coming from a Moment renderer, and handling appropriately.

@daxfohl daxfohl requested review from a team, vtomole and cduck as code owners July 15, 2022 17:04
@daxfohl daxfohl requested a review from maffoo July 15, 2022 17:04
@CirqBot CirqBot added the size: S 10< lines changed <50 label Jul 15, 2022
@95-martin-orion 95-martin-orion added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 18, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 18, 2022
@CirqBot
Copy link
Collaborator

CirqBot commented Jul 18, 2022

Automerge cancelled: A status check is failing.

@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 18, 2022
@95-martin-orion 95-martin-orion added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 18, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 18, 2022
@CirqBot CirqBot merged commit 27b5d4b into quantumlib:master Jul 18, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 18, 2022
@daxfohl daxfohl deleted the fix-cco-moment branch October 12, 2022 00:49
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Fixes quantumlib#5776 by accounting for the fact that `args.label_map` is null when coming from a Moment renderer, and handling appropriately.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Printing Moment containing classical control fails
3 participants