Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move AQTTargetGateset to its own module #5782

Merged
merged 5 commits into from
Jul 16, 2022

Conversation

pavoljuhas
Copy link
Collaborator

Add tests to complete test coverage of AQTTargetGateset.
Update _decompose_single_qubit_operation to check the
type of the wrapped gate, disregarding CircuitOperation
and TaggedOperation wrappers.

Fixes #5698

Not yet working when HPowGate is wrapped in tagged/circuit operation.
Disregard TaggedOperation, CircuitOperation wrappers and check
the type of the actual unwrapped gate.
@pavoljuhas pavoljuhas requested a review from viathor July 15, 2022 22:51
@CirqBot CirqBot added the size: M 50< lines changed <250 label Jul 15, 2022
Copy link
Collaborator

@dstrain115 dstrain115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cirq-aqt/cirq_aqt/aqt_target_gateset.py Outdated Show resolved Hide resolved
@pavoljuhas pavoljuhas added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 16, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 16, 2022
@CirqBot CirqBot merged commit 7632fc5 into quantumlib:master Jul 16, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 16, 2022
@pavoljuhas pavoljuhas deleted the new-home-for-AQTTargetGateset branch July 16, 2022 07:01
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Add tests to complete test coverage of AQTTargetGateset.
Update `_decompose_single_qubit_operation` to check the
type of the wrapped gate, disregarding CircuitOperation
and TaggedOperation wrappers.

Fixes quantumlib#5698
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complete coverage of aqt_device.py
3 participants