Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle global phase gate in single-qubit merge transformers #5786

Merged
merged 4 commits into from
Jul 17, 2022
Merged

Handle global phase gate in single-qubit merge transformers #5786

merged 4 commits into from
Jul 17, 2022

Conversation

viathor
Copy link
Collaborator

@viathor viathor commented Jul 16, 2022

Fixes #5785.

@viathor viathor requested review from a team, vtomole and cduck as code owners July 16, 2022 02:16
@CirqBot CirqBot added the size: S 10< lines changed <50 label Jul 16, 2022
pavoljuhas
pavoljuhas approved these changes Jul 17, 2022
View reviewed changes
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a tiny change.

cirq-core/cirq/transformers/merge_single_qubit_gates.py Outdated Show resolved Hide resolved
@viathor viathor force-pushed the handle_global_phase_in_sq_merge_transformers branch from 50c6d88 to 5082c4b Compare July 17, 2022 02:16
@viathor viathor added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 17, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 17, 2022
@CirqBot CirqBot merged commit 80b335b into quantumlib:master Jul 17, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 17, 2022
@viathor viathor deleted the handle_global_phase_in_sq_merge_transformers branch July 17, 2022 03:37
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@viathor @rht
Handle global phase gate in single-qubit merge transformers (quantuml…
cc4cc9a 
…ib#5786)

Fixes quantumlib#5785.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavoljuhas pavoljuhas pavoljuhas approved these changes

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@95-martin-orion 95-martin-orion Awaiting requested review from 95-martin-orion 95-martin-orion was automatically assigned from quantumlib/cirq-maintainers

Assignees
No one assigned
Labels
size: S 10< lines changed <50
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

merge_single_qubit_gates_to_phxz raises IndexError when encountering GlobalPhaseGate
3 participants
@viathor @pavoljuhas @CirqBot