-
Notifications
You must be signed in to change notification settings - Fork 997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict numpy version to unblock inflight PRs from failing #5853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstrain115
approved these changes
Sep 2, 2022
pavoljuhas
added a commit
to pavoljuhas/Cirq
that referenced
this pull request
Sep 3, 2022
…uantumlib#5853)" This reverts commit fb1b9bc.
CirqBot
pushed a commit
that referenced
this pull request
Sep 6, 2022
- Revert "Restrict numpy version to unblock inflight PRs from failing (#5853)" - Clarify wording of ValueError message - Fix typing complaints on non-native numeric types - Fix complaint on float.__rpow__(cirq.Operation) use - cirq.Operation has no `__pow__`, but the GateOperation subclass has - Fix complaint about vstack on generic array - clean up unused "type: ignore" comments Resolves #5852. Reverts #5853.
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…ib#5853) * Remove stale TODO * Restrict numpy version
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
- Revert "Restrict numpy version to unblock inflight PRs from failing (quantumlib#5853)" - Clarify wording of ValueError message - Fix typing complaints on non-native numeric types - Fix complaint on float.__rpow__(cirq.Operation) use - cirq.Operation has no `__pow__`, but the GateOperation subclass has - Fix complaint about vstack on generic array - clean up unused "type: ignore" comments Resolves quantumlib#5852. Reverts quantumlib#5853.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest release of numpy breaks type checks on master.
See https://github.com/quantumlib/Cirq/runs/8161863398?check_suite_focus=true for failing tests.
Part of #5852
This PR restricts the version of numpy to unblock the in-flight PRs.