fixed XPowGate matrix description #5946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let t = 1. Then the XPowGate matrix should be a phase factor times the Pauli X-matrix, which means that the first coefficient should equal 0. As written, the first coefficient is equal to a phase factor times \cos(\pi t), which does not equal 0.
michaelontiveros
requested review from
a team,
vtomole and
cduck
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
viathor
approved these changes
Nov 10, 2022
cirq-core/cirq/ops/common_gates.py
Outdated
| e^{i \pi t /2} \cos(\pi t) & -i e^{i \pi t /2} \sin(\pi t) \\ | ||
| -i e^{i \pi t /2} \sin(\pi t) & e^{i \pi t /2} \cos(\pi t) | ||
| e^{i \pi t /2} \cos(\pi t /2) & -i e^{i \pi t /2} \sin(\pi t /2) \\ | ||
| -i e^{i \pi t /2} \sin(\pi t /2) & e^{i \pi t /2} \cos(\pi t /2) |
There was a problem hiding this comment.
The e^{i \pi t /2} factor is on every matrix element, so for readability we should pull it out and combine with e^{i \pi s t}. Could you please do this while you're at it? :-)
There was a problem hiding this comment.
Gladly
I moved the e^{i \pi t /2} factors to the front, as you suggested :-)
viathor
added
the
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let t = 1.
Then the XPowGate matrix should be a phase factor times the Pauli X-matrix,
which means that the first coefficient should equal 0.
As written, the first coefficient is equal to a phase factor times \cos(\pi t),
which does not equal 0.