New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add single-qubit detuning parameters to CouplerPulse #5971
Conversation
Not sure of the etiquette here (and whether I should merge back into the original), but this extends and fixes the tests in #5965. |
'rise_time', | ||
'padding_time', | ||
'q0_detune_mhz', | ||
'q1_detune_mhz', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this fail to deserialize old CouplerPulse objects without these values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a test that demonstrates that deserialization continues to work: test_coupler_pulse_json_deserialization_defaults_on_missing_fields
Clone of
u/maffoo/coupler-pulse
with test fixes.