Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streaming client prototype: EngineClient interface and stream handler #5982

Closed
wants to merge 2 commits into from

Conversation

verult
Copy link
Collaborator

@verult verult commented Jan 10, 2023

A prototype of EngineClient.create_job_and_get_result() covering the happy path only; it doesn't handle stream disconnects, so it never makes a GetResult call over the stream.

The prototype contains:

  • A long running stream handler to receive stream responses
    • Runs in the asyncio context.
    • Handler restart logic (including making a GetResult request for every outstanding job in Response Listener) is missing
  • Response listener
  • EngineClient.create_job_and_get_result() implementation to send requests to the request stream directly and receive responses from the Response Listener.
    • The request stream data structure is not yet thread-safe.

cc @maffoo @wcourtney

@verult verult requested review from wcourtney, a team, vtomole and cduck as code owners January 10, 2023 22:22
@verult verult requested a review from viathor January 10, 2023 22:22
@CirqBot CirqBot added the size: M 50< lines changed <250 label Jan 14, 2023
@verult verult mentioned this pull request Feb 3, 2023
8 tasks
@verult verult changed the title [WIP] Streaming client prototype Streaming client prototype Jun 7, 2023
@verult verult mentioned this pull request Jun 7, 2023
@verult verult changed the title Streaming client prototype Streaming client prototype: EngineClient interface and stream handler Jun 10, 2023
@verult verult marked this pull request as draft June 15, 2023 23:27
@verult
Copy link
Collaborator Author

verult commented Oct 20, 2023

The actual implementation has been merged (#6199). Closing

@verult verult closed this Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants