Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Node version #6014

Merged
merged 4 commits into from Feb 21, 2023
Merged

Pin Node version #6014

merged 4 commits into from Feb 21, 2023

Conversation

vtomole
Copy link
Collaborator

@vtomole vtomole commented Feb 21, 2023

The previous Typescript checks were automatically picking the latest version of Node.

Fixes: #5292 (comment)

@vtomole vtomole marked this pull request as ready for review February 21, 2023 23:26
@vtomole vtomole requested review from a team and cduck as code owners February 21, 2023 23:26
@vtomole vtomole changed the title TESTING: output node version Pin Node version Feb 21, 2023
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder if actions/setup-node@v2 will help with #5998, which as is is at v3.

@vtomole
Copy link
Collaborator Author

vtomole commented Feb 21, 2023

Worth a try.

@vtomole vtomole merged commit 1ad63aa into master Feb 21, 2023
@vtomole vtomole deleted the vtomole-patch-2 branch February 21, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants