Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add weekly CI workflow to test all notebooks #6046

Merged
merged 3 commits into from
Apr 11, 2023

Conversation

xXnathankerrXx
Copy link
Contributor

Verified "changed notebooks" and "all notebooks" tests run when pytest is called with the respective mark and skipped otherwise.

I didn't find a good way to test the scheduled Action. Let me know if there's a good way.

Fixes #6037

@xXnathankerrXx xXnathankerrXx requested review from a team, vtomole and cduck as code owners March 31, 2023 02:51
@CirqBot CirqBot added the size: M 50< lines changed <250 label Mar 31, 2023
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing this!
Looks good to go to me after a few small updates.

.github/workflows/ci-weekly.yml Outdated Show resolved Hide resolved
dev_tools/notebooks/isolated_notebook_test.py Outdated Show resolved Hide resolved
@xXnathankerrXx
Copy link
Contributor Author

Thanks for the review. Made the requested changes and rebased against master.

Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI - run weekly isolated_notebook_test for all notebooks
3 participants