Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Default InsertStrategy in Circuits Notebook #6079

Merged
merged 2 commits into from Apr 25, 2023

Conversation

xXnathankerrXx
Copy link
Contributor

Minor fix in Circuits notebook.

According to both the reference docs and source, the default InsertStrategy is EARLIEST.

According to both the reference docs and the source code, the default
InsertStrategy is EARLIEST.
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CirqBot CirqBot added the Size: XS <10 lines changed label Apr 25, 2023
Copy link
Collaborator

@dabacon dabacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. A long time ago NEW_THEN_INLINE was the default.

@pavoljuhas pavoljuhas enabled auto-merge (squash) April 25, 2023 17:16
@pavoljuhas pavoljuhas merged commit ae336a6 into quantumlib:master Apr 25, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: XS <10 lines changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants