Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Device Parameter metadata serialization to cirq_google #6113

Merged
merged 7 commits into from Jun 22, 2023
Merged

Add Device Parameter metadata serialization to cirq_google #6113

merged 7 commits into from Jun 22, 2023

Conversation

dstrain115
Copy link
Collaborator

  • Allow DeviceParameter to be serialized as part of cirq_google.

@dstrain115
Add Device Parameter metadata serialization to cirq_google
fae10c7 
- Allow DeviceParameter to be serialized as part of cirq_google.
@CirqBot CirqBot added the size: XL lines changed >1000 label May 31, 2023
pavoljuhas
pavoljuhas approved these changes May 31, 2023
View reviewed changes
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after filling up the test coverage.

@dstrain115
Copy link
Collaborator Author

This PR is on hold per request of @maffoo

@dstrain115 dstrain115 marked this pull request as draft May 31, 2023 22:50
@dstrain115 dstrain115 marked this pull request as ready for review June 20, 2023 20:16
@dstrain115 dstrain115 enabled auto-merge (squash) June 22, 2023 16:00
@dstrain115 dstrain115 merged commit f3965e8 into quantumlib:master Jun 22, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavoljuhas pavoljuhas pavoljuhas approved these changes

@wcourtney wcourtney Awaiting requested review from wcourtney

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@verult verult Awaiting requested review from verult

Assignees
No one assigned
Labels
size: XL lines changed >1000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dstrain115 @pavoljuhas @CirqBot