Add new subpackage cirq-ft #6121
Conversation
Prefer pathlib to io, ensure file objects are closed.
| circuits and running them against quantum computers and simulators. | ||
|
|
||
| This module is **cirq-ft**, which enhances support for fault-tolerant algorithms | ||
| and provides functions for quantum memory management. |
There was a problem hiding this comment.
Cirq's github homepage defines it as
A python framework for creating, editing, and invoking Noisy Intermediate Scale Quantum (NISQ) circuits.
Wikipedia says that
Cirq is an open-source framework for noisy intermediate scale quantum (NISQ) computers.
Perhaps the README.md should discuss (and maybe even resolve!) this apparent contradiction.
There was a problem hiding this comment.
Ack. This PR is to add a minimum package for transferring code from a development non-public repository.
The README file is not yet ready; I have added a TODO marker it needs to be reviewed.
cirq-ft/setup.py
Outdated
|
|
||
| name = 'cirq-ft' | ||
|
|
||
| description = 'A Cirq package to fault-tolerant algorithms' |
There was a problem hiding this comment.
Thank you, fixed.
And fix typo in the package description.
Problem: pytest fails if it cannot find any test module in cirq-ft Solution: add a temporary test-nothing test module to cirq-ft
|
|
||
| """Define version number here, read it from setup.py automatically""" | ||
|
|
||
| __version__ = "1.2.0.dev" |
There was a problem hiding this comment.
@verult Can we do 0.1.0dev instead?
There was a problem hiding this comment.
A big benefit of keeping the same version is that the compatibility matrix between vendor packages and cirq-core is simple: vendor package version 1.2.3 depends on cirq-core 1.2.3. I think using 0.x.x for a new packages makes sense, and we can even bump major and minor versions at a different cadence as cirq-core if our release tools allow, but we should then document compatibility with cirq-core in the README.
For example, if say cirq-ft 0.3.0 requires cirq-core 1.3 features:
- cirq-ft 0.1 - 0.2 : >= cirq-core 1.2
- cirq-ft 0.3: >= cirq-core 1.3
There was a problem hiding this comment.
IIUC the plan is to distribute cirq-ft together with cirq. For example, the cirq metapackage currently includes all submodules including cirq-ft.
Lines 53 to 54 in 49b2cfb
If that is the case, I think it is better to keep cirq-ft version in sync with all other versions in cirq.
We can consider cirq-ft to be a new capability provided with the next public version Cirq-1.2.0.
Partially fixes #6119