Thread-safe implementation of AsyncCollector #6132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maffoo
reviewed
Jun 9, 2023
| if not self._done and not self._buffer: | ||
| self._waiter = duet.AwaitableFuture() | ||
| self._lock.release() | ||
| await self._waiter |
There was a problem hiding this comment.
If this raises we will double-release when exiting the outer with self._lock block. Probably don't want to mix manual lock acquire and release calls and with statements here.
There was a problem hiding this comment.
Thanks for the catch! Updated.
Closed
|
The actual stream implementation has been merged (#6199). Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be used as the request queue, where requests are produced in both the duet and asyncio event loops, and are consumed in the asyncio event loop.
This can be upstreamed to duet.
cc @maffoo @wcourtney