Add units to device parameter #6140
Conversation
dstrain115
commented
Jun 12, 2023
dstrain115
commented
- Add the ability to add unit type for a device parameter. - This will be important for server-side deserialization, where the server will need to know what units the float values are in.
- This will allow us to do sweeps of parameters that have units, such as nanoseconds, or GigaHertz.
dstrain115
requested review from
wcourtney,
a team,
vtomole,
cduck and
verult
as code owners
| """ | ||
|
|
||
| path: Sequence[str] | ||
| idx: Optional[int] = None | ||
| value: Optional[Any] = None | ||
| units: Optional[str] = None |
There was a problem hiding this comment.
Is there a plan for exposing the spec for units? i.e. how do users know the valid options here? If there's a limited subset of Pyle units that we support, might it be worth providing those explicitly?
There was a problem hiding this comment.
To answer this comment a bit belatedly, there isn't an immediate plan to expose the units. However, there is also no plan to expose the valid path either. Users will generally need an expert internal user in order to use this feature anyway.
The valid spec is to use labrad units, which we may eventually expose, but this is a longer term project. We probably should revisit this when we start looking at how we want to integrate services like reg/DV with cirq_google.
