Allow measure_single_paulistring to have negative coefficient #6143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| with pytest.raises(ValueError, match='must have a coefficient'): | ||
| _ = cirq.measure_single_paulistring(-ps) | ||
| _ = cirq.measure_single_paulistring(-2*ps) |
There was a problem hiding this comment.
Add the example in the original issue as a test for cirq.measure_single_paulistring to show that it now successfully creates the expected PauliMeasurementGate
tanujkhattar
approved these changes
Jun 13, 2023
Co-authored-by: Tanuj Khattar <tanujkhattar@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had a check to make sure the coefficient of the paulistring passed to measure_single_paulistring had a coefficient of 1 but we support +1 and -1. Check out #6137 for context.
Fixes #6137