Remove dependency on the flynt tool #6164
Conversation
NumPy is guaranteed to be installed with cirq.
Use correct markup for ignoring coverage. And also remove duplicate import.
Add TODO note to fix these later.
pavoljuhas
requested review from
HGSilveri,
a team,
vtomole,
cduck,
wcourtney and
verult
as code owners
|
Is flynt not able to convert files for which have added explicit TODOs? It looks like we are adding a LOT of TODOs to the codebase -- what's the plan to get rid of them? Can we experiment with automated tools and change these files as part of this PR itself instead of adding a that many TODOs ? |
The plan is to address TODO-s in a follow-up PR which will only change the string expressions without changing their values, #6171 (comment). The second PR can be added to .git-blame-ignore-revs without masking away the actual changes in As for the automated changes, I tested with flynt on one file and it seems to do the job. Still I would like to put these no-op changes to a separate PR. |
There was a problem hiding this comment.
@pavoljuhas Okay, I'll approve this PR and let's merge it; but can you make sure we get in the follow up soon so we don't leave the TODOs for a long time?
Sounds good will do. |
Partially fixes #6171