Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid extra commas from json data #6176

Merged
merged 2 commits into from Jun 29, 2023

Conversation

pavoljuhas
Copy link
Collaborator

Ensure all json files pass the following validation

$ git ls-files *.json |
    while read f; do python -m json.tool $f >/dev/null || echo $f; done

@pavoljuhas pavoljuhas requested review from a team, vtomole and cduck as code owners June 29, 2023 02:06
@CirqBot CirqBot added the Size: XS <10 lines changed label Jun 29, 2023
@viathor
Copy link
Collaborator

viathor commented Jun 29, 2023

(If you're going to rely on this, consider adding a CI check.)

@pavoljuhas
Copy link
Collaborator Author

(If you're going to rely on this, consider adding a CI check.)

Ack. I noticed this when reviewing a recent change in asv.conf.json where my editor highlighted syntax error.
Only 2 out of 256 json files failed validation with json.tool. I feel a CI check is not quite warranted.

@pavoljuhas pavoljuhas enabled auto-merge (squash) June 29, 2023 20:12
@pavoljuhas pavoljuhas merged commit 7b753f6 into quantumlib:master Jun 29, 2023
30 checks passed
@pavoljuhas pavoljuhas deleted the fix-extra-json-commas branch June 29, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: XS <10 lines changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants