Add Python 3.11 tests to CI #6191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maffoo
approved these changes
Jul 11, 2023
wcourtney
approved these changes
Jul 11, 2023
| proto-plus >= 1.20.0 | ||
| protobuf >= 3.15.0, < 4 | ||
| protobuf >= 3.15.0 |
There was a problem hiding this comment.
As noted in chat, proto4 was breaking cirq_google: #5355
If that's resolved then LGTM!
pavoljuhas
reviewed
Jul 11, 2023
There was a problem hiding this comment.
I think it would be better to split this to 2 PRs -
- PR1 - upgrade protobuf to 4.0
- PR2 - add Python 3.11 CI tests
In my previous attempt on PR1 I had to fix a few expected textprotos - #5951, perhaps that is still needed to pass tests for the supported Pythons.
pavoljuhas
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #6181, which adds support for Python 3.11 to Cirq.