Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov coverage reports #6193

Merged
merged 6 commits into from Jul 25, 2023

Conversation

jackreeceejini
Copy link
Contributor

Testing Codecov coverage reports on a PR as per #6063 (comment)

@jackreeceejini jackreeceejini requested review from a team, vtomole and cduck as code owners July 11, 2023 16:35
@CirqBot CirqBot added the Size: XS <10 lines changed label Jul 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@43d0372). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6193   +/-   ##
=========================================
  Coverage          ?   97.37%           
=========================================
  Files             ?     1115           
  Lines             ?    95583           
  Branches          ?        0           
=========================================
  Hits              ?    93070           
  Misses            ?     2513           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavoljuhas
Copy link
Collaborator

Please rebase so this PR contains only codecov-related commits on top of the quantumlib/Cirq master.
As it is the PR has intermediate commits from your previous contribution.

One way of doing the rebase is

$ git checkout codecov-coverage-reports
$ git fetch https://github.com/quantumlib/Cirq.git master
$ git rebase -i FETCH_HEAD
  ... keep only the new commits
$ git push --force-with-lease your_remote_name codecov-coverage-reports

@jackreeceejini
Copy link
Contributor Author

I will, thank you very much. I'm learning a lot!

Comment on lines 243 to 245
env:
# Admin required to access repo settings > secrets and variable > actions
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can take this out, the token is not needed for public repositories - https://github.com/codecov/codecov-action#usage.

Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dstrain115 has installed the Codecov App and we got our first coverage report out at
https://app.codecov.io/github/quantumlib/Cirq/commit/1fd59723ba339b9281d150d31825c3791e4f0fdc/tree 🎉

LGTM after removing the unused token settings.

Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pavoljuhas pavoljuhas enabled auto-merge (squash) July 25, 2023 01:01
@pavoljuhas pavoljuhas merged commit 76b8a96 into quantumlib:master Jul 25, 2023
32 of 33 checks passed
@jackreeceejini jackreeceejini deleted the codecov-coverage-reports branch July 25, 2023 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: XS <10 lines changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants