Make Cirq-FT registers multi-dimensional #6200
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
|
cirq-ft/cirq_ft/algos/and_gate.py
Outdated
| ) -> cirq.OP_TREE: | ||
| control, ancilla, target = quregs['control'], quregs['ancilla'], quregs['target'] | ||
| if len(self.cv) == 2: | ||
| yield self._decompose_single_and( | ||
| self.cv[0], self.cv[1], control[0], control[1], *target | ||
| ) | ||
| else: | ||
| yield self._decompose_via_tree(control, self.cv, ancilla, *target) | ||
| yield self._decompose_via_tree(control.tolist(), self.cv, ancilla.tolist(), *target) |
There was a problem hiding this comment.
why do we need tolist()? Do we need to update the type signatures for _decompose_via_tree if we're using list-specific things
There was a problem hiding this comment.
We need this mainly because Sequence[cirq.Qid] is not compatible with NDArray[cirq.Qid].
I'll update the signature of _decompose_via_tree to accept NDArray[cirq.Qid] instead.
There was a problem hiding this comment.
that's kindof annoying
|
|
||
| @classmethod | ||
| def build(cls, **registers: int) -> 'Registers': | ||
| return cls(Register(name=k, bitsize=v) for k, v in registers.items()) | ||
| def build(cls, **registers: Union[int, Tuple[int, ...]]) -> 'Registers': |
There was a problem hiding this comment.
this is going to be really screwwy when combined with SelectionRegisters.build
There was a problem hiding this comment.
Hmm, I'll change SelectionRegisters.build to follow the Register.build interface and use 2 ** self.shape[0] as the default iteration length. All call sites using non-default iteration length will be updated to use the full constructor
…i_dimensional_registers
…i_dimensional_registers
…i_dimensional_registers
|
@mpharrigan I've addressed all your comments and updated the PR. |
…i_dimensional_registers
This brings the Cirq-FT registers one step closer to Qualtran registers.
Some notable changes in this PR:
Register.bitsizeis nowRegister.shapeand a tuple instead of integertotal_bitstoRegisterclass.Registers.bitsizeis nowRegisters.total_bits()SelectionRegisters.buildinterface is changed to matchRegisters.buildand all call sites are updated to use explicit constructor ifiteration_lengthis non trivial (i.e. not2 ** self.shape[0])SwapWithZeroclass where the target register is now 2D.cc @mpharrigan
Fixes #6053