Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use f-strings in the pr_monitor tool #6208

Merged
merged 5 commits into from Jul 22, 2023
Merged

Use f-strings in the pr_monitor tool #6208

merged 5 commits into from Jul 22, 2023

Conversation

pavoljuhas
Copy link
Collaborator

@pavoljuhas pavoljuhas commented Jul 18, 2023 •
edited

  • pr_monitor - convert to f-strings to satisfy pylint consider-using-f-string
  • and clean up some redundant fixed strings concatenations

Finalizes #6171

@CirqBot CirqBot added the size: M 50< lines changed <250 label Jul 18, 2023
@pavoljuhas pavoljuhas requested a review from viathor July 18, 2023 01:16
viathor
viathor approved these changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@viathor viathor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pavoljuhas pavoljuhas enabled auto-merge (squash) July 22, 2023 05:27
@pavoljuhas pavoljuhas merged commit 43d0372 into quantumlib:master Jul 22, 2023
32 of 33 checks passed
@pavoljuhas pavoljuhas deleted the use-f-strings-in-pr_monitor branch July 25, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viathor viathor viathor approved these changes

@wcourtney wcourtney Awaiting requested review from wcourtney

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@verult verult Awaiting requested review from verult

Assignees
No one assigned
Labels
size: M 50< lines changed <250
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pavoljuhas @viathor @CirqBot