add cirq specific environment variables to ionq

[splch]

can specify CIRQ_IONQ_API_KEY to override a global IONQ_API_KEY environment variable.

[pavoljuhas]

Please update unit tests for the new logic with environment variables.

Since you'd be likely changing the tests below, can you please also replace os.environ[...] = ... with mock.patch.dict(os.environ, {...}?

Cirq/cirq-ionq/cirq_ionq/service_test.py

Lines 161 to 172 in b6a7087

	def test_service_api_key_via_env():
	os.environ['IONQ_API_KEY'] = 'tomyheart'
	service = ionq.Service(remote_host='http://example.com')
	assert service.api_key == 'tomyheart'
	del os.environ['IONQ_API_KEY']
	def test_service_remote_host_via_env():
	os.environ['IONQ_REMOTE_HOST'] = 'http://example.com'
	service = ionq.Service(api_key='tomyheart')
	assert service.remote_host == 'http://example.com'
	del os.environ['IONQ_REMOTE_HOST']

[codecov-commenter]

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (43f6a7f) 97.36% compared to head (05de92d) 97.36%.
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6216      +/-   ##
==========================================
- Coverage   97.36%   97.36%   -0.01%     
==========================================
  Files        1115     1116       +1     
  Lines       95658    95700      +42     
==========================================
+ Hits        93141    93179      +38     
- Misses       2517     2521       +4     

Files Changed	Coverage Δ
cirq-google/cirq_google/engine/asyncio_executor.py	100.00% <100.00%> (ø)
cirq-google/cirq_google/engine/engine_client.py	100.00% <100.00%> (ø)
cirq-ionq/cirq_ionq/service.py	100.00% <100.00%> (ø)
cirq-ionq/cirq_ionq/service_test.py	100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[splch]

Please update unit tests for the new logic with environment variables.

Since you'd be likely changing the tests below, can you please also replace os.environ[...] = ... with mock.patch.dict(os.environ, {...}?

Cirq/cirq-ionq/cirq_ionq/service_test.py

Lines 161 to 172 in b6a7087

	def test_service_api_key_via_env():
	os.environ['IONQ_API_KEY'] = 'tomyheart'
	service = ionq.Service(remote_host='http://example.com')
	assert service.api_key == 'tomyheart'
	del os.environ['IONQ_API_KEY']
	def test_service_remote_host_via_env():
	os.environ['IONQ_REMOTE_HOST'] = 'http://example.com'
	service = ionq.Service(api_key='tomyheart')
	assert service.remote_host == 'http://example.com'
	del os.environ['IONQ_REMOTE_HOST']

got it thanks!

[pavoljuhas]

Please pass os.environ as is instead of as a string.
For these tests you can consider decorating the test method, for example,

@mock.patch.dict(os.environ, {'IONQ_API_KEY': 'tomyheart'})
def test_service_api_key_via_env():
    service = ionq.Service(remote_host='http://example.com')
    ... 

Note if needed, you can also modify os.environ in the test function body. Any changes will be reverted when function returns and exits the patch.dict context.

[pavoljuhas]

Please use os.environ object instead of "os.environ" string, it will satisfy the failing lint check.
Also, CIRQ_IONQ_REMOTE_HOST seems untested.

[splch]

Please use os.environ object instead of "os.environ" string, it will satisfy the failing lint check. Also, CIRQ_IONQ_REMOTE_HOST seems untested.

thanks for the help :) this latest pr should cover the changes

[pavoljuhas]

LGTM, Thank you!