Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cirq-FT] Fix typo and add more helpful assertion message. #6221

Merged
merged 2 commits into from Jul 31, 2023

Conversation

fdmalone
Copy link
Contributor

I often hit this assertion and have to poke around to figure out which register is missing. pe -> be.

@fdmalone fdmalone requested review from a team, vtomole and cduck as code owners July 31, 2023 16:47
@CirqBot CirqBot added the Size: XS <10 lines changed label Jul 31, 2023
@tanujkhattar tanujkhattar enabled auto-merge (squash) July 31, 2023 21:48
@tanujkhattar tanujkhattar added the area/cirq-ft Issues related to the Cirq-FT sub-package label Jul 31, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (91f690d) 97.36% compared to head (510cde3) 97.36%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6221      +/-   ##
==========================================
- Coverage   97.36%   97.36%   -0.01%     
==========================================
  Files        1116     1116              
  Lines       95700    95700              
==========================================
- Hits        93178    93177       -1     
- Misses       2522     2523       +1     
Files Changed Coverage Δ
cirq-core/cirq/testing/consistent_qasm_test.py 90.24% <100.00%> (ø)
cirq-ft/cirq_ft/infra/gate_with_registers.py 95.51% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tanujkhattar tanujkhattar merged commit c15dd03 into quantumlib:master Jul 31, 2023
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cirq-ft Issues related to the Cirq-FT sub-package Size: XS <10 lines changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants