Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin mypy-protobuf version and fix failing qasm test #6222

Merged
merged 4 commits into from Jul 31, 2023
Merged

Pin mypy-protobuf version and fix failing qasm test #6222

merged 4 commits into from Jul 31, 2023

Conversation

tanujkhattar
Copy link
Collaborator

@tanujkhattar tanujkhattar commented Jul 31, 2023 •
edited

Fixes #6223

@tanujkhattar tanujkhattar changed the title Pin mypy-protobuf version Pin mypy-protobuf version and fix failing qasm test Jul 31, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (91f690d) 97.36% compared to head (8b6bf01) 97.36%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6222   +/-   ##
=======================================
  Coverage   97.36%   97.36%           
=======================================
  Files        1116     1116           
  Lines       95700    95700           
=======================================
+ Hits        93178    93180    +2     
+ Misses       2522     2520    -2
Files Changed Coverage Δ
cirq-core/cirq/testing/consistent_qasm_test.py 90.24% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tanujkhattar tanujkhattar marked this pull request as ready for review July 31, 2023 19:29
@tanujkhattar tanujkhattar requested review from a team, vtomole and cduck as code owners July 31, 2023 19:29
@tanujkhattar tanujkhattar enabled auto-merge (squash) July 31, 2023 19:35
@tanujkhattar tanujkhattar merged commit 1c038c3 into quantumlib:master Jul 31, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoureldinYosri NoureldinYosri NoureldinYosri approved these changes

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@95-martin-orion 95-martin-orion Awaiting requested review from 95-martin-orion 95-martin-orion was automatically assigned from quantumlib/cirq-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests failing on master
2 participants
@tanujkhattar @NoureldinYosri