Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Isolated pytest #6229

Merged
merged 16 commits into from Aug 4, 2023
Merged

Fix Isolated pytest #6229

merged 16 commits into from Aug 4, 2023

Conversation

NoureldinYosri
Copy link
Collaborator

@NoureldinYosri NoureldinYosri commented Aug 2, 2023 •
edited

  • add the notebook dependencies to the isolated env
  • use the correct requirements file in the test

@CirqBot CirqBot added the Size: XS <10 lines changed label Aug 2, 2023
@NoureldinYosri NoureldinYosri linked an issue Aug 2, 2023 that may be closed by this pull request
Cirq-FT: Isolated pytest fails at head for cirq-ft notebooks #6227
Closed
@codecov
Copy link

codecov bot commented Aug 2, 2023 •
edited

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (701538c) 97.37% compared to head (078e64d) 97.37%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6229   +/-   ##
=======================================
  Coverage   97.37%   97.37%           
=======================================
  Files        1116     1116           
  Lines       95708    95708           
=======================================
  Hits        93191    93191           
  Misses       2517     2517
Files Changed Coverage Δ
dev_tools/packaging/isolated_packages_test.py 61.11% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NoureldinYosri NoureldinYosri changed the title add ipykernel as dependency Fix Isolated pytest Aug 4, 2023
@NoureldinYosri NoureldinYosri marked this pull request as ready for review August 4, 2023 11:21
@NoureldinYosri NoureldinYosri requested review from vtomole, cduck and a team as code owners August 4, 2023 11:21
@NoureldinYosri NoureldinYosri enabled auto-merge (squash) August 4, 2023 12:38
@NoureldinYosri NoureldinYosri enabled auto-merge (squash) August 4, 2023 12:38
@NoureldinYosri NoureldinYosri merged commit c5afcce into master Aug 4, 2023
35 checks passed
@NoureldinYosri NoureldinYosri deleted the notebooks branch August 4, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstrain115 dstrain115 dstrain115 approved these changes

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@MichaelBroughton MichaelBroughton Awaiting requested review from MichaelBroughton MichaelBroughton was automatically assigned from quantumlib/cirq-maintainers

@tanujkhattar tanujkhattar Awaiting requested review from tanujkhattar

Assignees
No one assigned
Labels
Size: XS <10 lines changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cirq-FT: Isolated pytest fails at head for cirq-ft notebooks
3 participants
@NoureldinYosri @dstrain115 @CirqBot