Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default for streaming feature flag to false #6310

Merged
merged 3 commits into from Nov 13, 2023

Conversation

verult
Copy link
Collaborator

@verult verult commented Oct 4, 2023

This PR is intended to be merged only in exceptional situations as a way to quickly turn the streaming feature off, e.g. when the feature misbehaves.

@verult verult requested review from wcourtney, vtomole, cduck and a team as code owners October 4, 2023 23:35
@verult verult requested a review from pavoljuhas October 4, 2023 23:35
@CirqBot CirqBot added the Size: XS <10 lines changed label Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0b90ed6) 97.84% compared to head (62eec67) 97.84%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6310   +/-   ##
=======================================
  Coverage   97.84%   97.84%           
=======================================
  Files        1108     1108           
  Lines       96398    96398           
=======================================
  Hits        94317    94317           
  Misses       2081     2081           
Files Coverage Δ
cirq-google/cirq_google/engine/engine.py 98.30% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@verult verult enabled auto-merge (squash) November 13, 2023 19:25
@verult verult merged commit 39bd926 into quantumlib:master Nov 13, 2023
35 checks passed
verult added a commit to verult/Cirq that referenced this pull request Dec 11, 2023
verult added a commit that referenced this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: XS <10 lines changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants