Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci - skip slow tests on PR, run them in daily ci instead #6331

Merged
merged 11 commits into from Oct 30, 2023
Merged

ci - skip slow tests on PR, run them in daily ci instead #6331

merged 11 commits into from Oct 30, 2023

Conversation

pavoljuhas
Copy link
Collaborator

@pavoljuhas pavoljuhas commented Oct 29, 2023 •
edited

  • Add slow marks to the unit tests with over 20 second duration.
  • Adjust ci-daily job so it runs all slow tests.
  • And add ci-daily jobs for Windows and MacOS operating systems
    so that slow tests get tested on those platforms too.

Refs:

Resolves #6211

@pavoljuhas
Apply slow mark for test_qrom_multi_dim[2-data0]
95b2969 
Also rewrite nested parametrization to a single parametrize decorator
providing the same argument values.
@pavoljuhas
Add slow mark to test_reflection_using_prepare
e6c9b34
@pavoljuhas
Add slow mark to test_selected_majorana_fermion_gate
3a85204 
Only apply for the larger (selection_bitsize, target_bitsize) values.
@pavoljuhas
Add slow mark to test_state_preparation_via_coherent_alias_sampling
6f006fc
@pavoljuhas
Add slow mark to test_qubitization_walk_operator
98033f5
@pavoljuhas
Apply slow mark for test_select_swap_qrom[3-data1]
08c7110 
Also rewrite nested parametrization to a single parametrize decorator
with the same argument values.
@pavoljuhas
Apply slow mark for test_qrom_1d[2-data2]
a10371c 
Also rewrite nested parametrization to a single parametrize decorator
with the same argument values.
@pavoljuhas
Execute all slow tests in ci-daily
95b20af
@CirqBot CirqBot added the size: M 50< lines changed <250 label Oct 29, 2023
@codecov
Copy link

codecov bot commented Oct 29, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1eced48) 97.89% compared to head (d3afedf) 97.83%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6331      +/-   ##
==========================================
- Coverage   97.89%   97.83%   -0.07%     
==========================================
  Files        1108     1108              
  Lines       96204    96203       -1     
==========================================
- Hits        94182    94121      -61     
- Misses       2022     2082      +60
Files Coverage Δ
cirq-ft/cirq_ft/algos/qrom_test.py 100.00% <ø> (ø)
...t/cirq_ft/algos/qubitization_walk_operator_test.py 69.62% <100.00%> (-30.38%) ⬇️
...-ft/cirq_ft/algos/reflection_using_prepare_test.py 61.64% <100.00%> (-38.36%) ⬇️
cirq-ft/cirq_ft/algos/select_swap_qrom_test.py 100.00% <100.00%> (ø)
...ft/cirq_ft/algos/selected_majorana_fermion_test.py 100.00% <100.00%> (ø)
cirq-ft/cirq_ft/algos/state_preparation_test.py 100.00% <100.00%> (ø)
cirq-ft/cirq_ft/algos/unary_iteration_gate_test.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavoljuhas
Apply slow mark for test_multi_dimensional_unary_iteration_gate[targe…
6e3fc70 
…t_shape0]
@pavoljuhas
Reapply slow marks for test_state_preparation_via_coherent_alias_samp…
8329cdf 
…ling

Enable the least slow of 4 test parametrizations.
@pavoljuhas
Add Windows and MacOS tests to ci-daily
d3afedf 
We run slow-marked cirq-ft tests here so we'd better
test for all supported operating systems.

Also use an explicit `check/pytest -n auto` in case the default
`-n auto` option in that script changes.
@pavoljuhas pavoljuhas marked this pull request as ready for review October 30, 2023 03:57
@pavoljuhas pavoljuhas requested review from vtomole, cduck and a team as code owners October 30, 2023 03:57
tanujkhattar
tanujkhattar approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@tanujkhattar tanujkhattar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pavoljuhas pavoljuhas merged commit 5556e72 into quantumlib:master Oct 30, 2023
35 checks passed
@pavoljuhas pavoljuhas deleted the ci-skip-slow-tests branch October 30, 2023 21:28
@pavoljuhas pavoljuhas mentioned this pull request Oct 31, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanujkhattar tanujkhattar tanujkhattar approved these changes

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@viathor viathor Awaiting requested review from viathor viathor was automatically assigned from quantumlib/cirq-maintainers

Assignees
No one assigned
Labels
size: M 50< lines changed <250
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI checks are slow, especially pytest and coverage
3 participants
@pavoljuhas @tanujkhattar @CirqBot