Run unit tests without affecting browser session #6333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exercise the `open_in_browser` argument from the test_generate_html_file_with_browser test, but do not affect the actual browser session.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6333 +/- ##
==========================================
- Coverage 97.83% 97.83% -0.01%
==========================================
Files 1108 1108
Lines 96266 96206 -60
==========================================
- Hits 94184 94124 -60
Misses 2082 2082
☔ View full report in Codecov by Sentry. |
tanujkhattar
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exercise the
open_in_browserargument in thetest_generate_html_file_with_browsertest, butdo not open a new tab or steal UI focus for the browser.