Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky behavior of test_xeb_fidelity #6337

Merged
merged 4 commits into from
Nov 2, 2023
Merged

Fix flaky behavior of test_xeb_fidelity #6337

merged 4 commits into from
Nov 2, 2023

Commits on Nov 2, 2023

  1. Fix flaky behavior of test_xeb_fidelity 

    Increase tolerance for fidelities calculated with and without state
vector amplitudes.  Avoid flaky, random-seed dependent test failures
on a slightly excessive difference.

Example: https://github.com/quantumlib/Cirq/actions/runs/6726576064/job/18283075054#step:6:598
    @pavoljuhas
    pavoljuhas committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    bfb58c2 View commit details
    Browse the repository at this point in the history

  2. Use np.allclose for more robust value comparison

    @pavoljuhas
    pavoljuhas committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    9ddcbaa View commit details
    Browse the repository at this point in the history

  3. Increase tolerance for fidelity comparison

    @pavoljuhas
    pavoljuhas committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    b5d72d5 View commit details
    Browse the repository at this point in the history

  4. Just go back to absolute values comparison 

    It is a fidelity after all.
    @pavoljuhas
    pavoljuhas committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    a53a76c View commit details
    Browse the repository at this point in the history