-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow measurement outcomes to be provided to the quantum board when performing moves #167
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should work nicely.
recirq/quantum_chess/move.py
Outdated
def __init__(self, | ||
source: str, | ||
target: str, | ||
*, | ||
source2: str = None, | ||
target2: str = None, | ||
move_type: enums.MoveType = None, | ||
move_variant: enums.MoveVariant = None): | ||
move_variant: enums.MoveVariant = None, | ||
measurement: bool = None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use an int for this instead? Is any one measurement "truer" than the other? And we also won't have to deal with the conversion in post_select later on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good thought. Int would also allow for the possibility of multi outcome measurements in the future
…ing on boards with readout error
Part of fixing issue #152