Update Cirq to 0.11 and Fixes #182
Conversation
|
We should change the PR name and description to match the fact that multiple changes (wrap_function, nbfmt, etc) are involved in this PR. Otherwise, it looks good so far. |
|
I was using this PR as a little testbed. I hope to merge those other changes independently and then rebase this one so it's only the Rx change |
PyTKet checks for gate equality instead of doing isinstance() checks, so Cirq's change to having a real Rx class breaks compilation. Change-Id: I36c04119ff01c28f44ff4a9296e8d6ae6dcb4de4
| │ │ │ │ │ │ | ||
| │ │ │ │ │ │ | ||
| │ │ │ │ │ │ | ||
| X X X X X X |
There was a problem hiding this comment.
annoyingly, this test behavior will now change depending on cirq version that you're using recirq with, although the circuits have the same effect.
There was a problem hiding this comment.
Optional: Is there a better way to test it besides testing the diagram output? If not, oh well I guess?
There was a problem hiding this comment.
I'll investigate. I think we have some tests for unitary equivalence, which is the important thing. This may have been an additional test to be sure (or to check for keeping the circuit structured how we expected)
Change-Id: I222bcab3840d96153e673adea4f7301dc98fe0b2
Change-Id: I27d2203521a7a9858db82d107433d21e47224f61
Change-Id: Id6b3def2817c4b2365cb7ad66aa7d43ce011b8f2
Change-Id: I819b8e69f4822939e38996ec477eb6b9bb543982
mpharrigan
changed the title
|
We don't have an automated test for the notebooks, but the fermi hubbard example is currently broken by the loss of |
Change-Id: Ie1332eb59f388e64b4a8d9fc10301fdf4e5c6ae4
| │ │ │ │ │ │ | ||
| │ │ │ │ │ │ | ||
| │ │ │ │ │ │ | ||
| X X X X X X |
There was a problem hiding this comment.
Optional: Is there a better way to test it besides testing the diagram output? If not, oh well I guess?
Change-Id: I4f81f623f26b7aa4e5943566986248a4a0dd8d3b
* Switch to using XPowGate instead of Rx PyTKet checks for gate equality instead of doing isinstance() checks, so Cirq's change to having a real Rx class breaks compilation. Change-Id: I36c04119ff01c28f44ff4a9296e8d6ae6dcb4de4 * requirements Change-Id: I222bcab3840d96153e673adea4f7301dc98fe0b2 * Pytket changes Change-Id: I27d2203521a7a9858db82d107433d21e47224f61 * Fix some deprecations Change-Id: Id6b3def2817c4b2365cb7ad66aa7d43ce011b8f2 * Fix some cirq.google deprecations Change-Id: I819b8e69f4822939e38996ec477eb6b9bb543982 * Split cirq into cirq-core and cirq-google Change-Id: Ie1332eb59f388e64b4a8d9fc10301fdf4e5c6ae4 * Bump version Change-Id: I4f81f623f26b7aa4e5943566986248a4a0dd8d3b
Devicecirq.google->cirq_googlemigration