Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON backwards compatibility has been flushed #4318

Closed
mpharrigan opened this issue Jul 13, 2021 · 1 comment · Fixed by #4319
Closed

JSON backwards compatibility has been flushed #4318

mpharrigan opened this issue Jul 13, 2021 · 1 comment · Fixed by #4319
Labels
kind/bug-report Something doesn't seem to work. priority: high This is something that should get done soon, e.g. within a month.

Comments

@mpharrigan
Copy link
Collaborator

#4099 cleared some deprecated classes. Serialized files have a much longer lifespan than code. It was always the intent to keep much longer-term backwards compatibility for data files, especially experimental results which likely have cirq.TrialResult classes.

  1. the old TrialResult.json should be kept around like the "inward" files
  2. The resolver should re-direct "TrialResult" keys to cirq.Result. In some sense, this should have been done along with the initial rename.
@mpharrigan mpharrigan added the kind/bug-report Something doesn't seem to work. label Jul 13, 2021
@mpharrigan mpharrigan mentioned this issue Jul 13, 2021
Closed
9 tasks
@dstrain115 dstrain115 added the priority: high This is something that should get done soon, e.g. within a month. label Jul 13, 2021
@dstrain115
Copy link
Collaborator

Oops, let's fix this ASAP.

@mpharrigan mpharrigan mentioned this issue Jul 14, 2021
Open
@MichaelBroughton MichaelBroughton mentioned this issue Jul 14, 2021
Merged
CirqBot pushed a commit that referenced this issue Jul 15, 2021
@MichaelBroughton
Re-alias TrialResult to Result in json. (#4319)
c629c38 
Fixes #4318  .

Relatively small roll-back and re-aliasing of `TrialResult`. Json loading will now convert previously serialized `TrialResult` to a `Result` object. Confirmed on `cirq==0.8.0` and `cirq-dev`
erichulburd pushed a commit to erichulburd/Cirq that referenced this issue Jul 15, 2021
@MichaelBroughton @erichulburd
Re-alias TrialResult to Result in json. (quantumlib#4319)
0e73dfd 
Fixes quantumlib#4318  .

Relatively small roll-back and re-aliasing of `TrialResult`. Json loading will now convert previously serialized `TrialResult` to a `Result` object. Confirmed on `cirq==0.8.0` and `cirq-dev`
MichaelBroughton added a commit to MichaelBroughton/Cirq that referenced this issue Jul 26, 2021
@MichaelBroughton
Re-alias TrialResult to Result in json. (quantumlib#4319)
12b438a 
Fixes quantumlib#4318  .

Relatively small roll-back and re-aliasing of `TrialResult`. Json loading will now convert previously serialized `TrialResult` to a `Result` object. Confirmed on `cirq==0.8.0` and `cirq-dev`
@MichaelBroughton MichaelBroughton mentioned this issue Jul 26, 2021
Closed
@mpharrigan mpharrigan mentioned this issue Jul 26, 2021
Merged
@mhucka mhucka mentioned this issue May 21, 2022
Open
rht pushed a commit to rht/Cirq that referenced this issue May 1, 2023
@MichaelBroughton @rht
Re-alias TrialResult to Result in json. (quantumlib#4319)
8b8496a 
Fixes quantumlib#4318  .

Relatively small roll-back and re-aliasing of `TrialResult`. Json loading will now convert previously serialized `TrialResult` to a `Result` object. Confirmed on `cirq==0.8.0` and `cirq-dev`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug-report Something doesn't seem to work. priority: high This is something that should get done soon, e.g. within a month.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-alias TrialResult to Result in json. MichaelBroughton/Cirq
2 participants
@mpharrigan @dstrain115