New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use safeMath and uint256 for compareFraction() #29

Closed

qizhou opened this issue Nov 6, 2019 · 0 comments · Fixed by #33

Assignees

Contributor

qizhou commented Nov 6, 2019

quarkchain-contracts/contracts/GeneralNativeTokenManager.sol

Line 177 in 39a3317

uint128 left = numerator1 * denominator2;

SafeMath already has an overflow check so we don't need the require's manually.

qizhou assigned jyouyj

ninjaahhh mentioned this issue

Update uint data type for gas reserve contract #33

Merged

ninjaahhh closed this as completed in #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment